De-duplicate peer connections during replication session updates #525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because peers listen on multiple local network addresses and often on discovery dial each other concurrently, it's very hard to set a "one connection per-peer" limit on established connections (we have managed to limit it to max two connections now, one as listener, one as dialer). We can however filter out any duplicate connections when choosing peers to initiate replication sessions with.
📋 Checklist
Add tests that cover your changesCHANGELOG.md